pytorch / benchmark

TorchBench is a collection of open source benchmarks used to evaluate PyTorch performance.
BSD 3-Clause "New" or "Revised" License
854 stars 275 forks source link

V2 Performance Signal Detected by TorchBench CI on '1b6d6e98fed5cdb0a0c2fedd5354dd8b83dd07f1' #1619

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

TorchBench CI has detected a performance signal or runtime regression.

Base PyTorch commit: 1b6d6e98fed5cdb0a0c2fedd5354dd8b83dd07f1

Affected PyTorch commit: 1b6d6e98fed5cdb0a0c2fedd5354dd8b83dd07f1

Affected Tests:

Tests that were no longer run on affected commit:

Tests that were newly added on affected commit:

Runtime regressions found? No runtime errors were found in the new benchmarks run--you are all good there!

GitHub workflow that triggered this issue: https://github.com/pytorch/benchmark/actions/runs/4911275907

cc @janeyx99

janeyx99 commented 1 year ago

I believe this is still just noise..I may need to up the threshold but would like to see some more data before doing that. Some observations: Total: 417 CUDA: 269 | CPU: 138 foreach: 255 | fused: 3 | ... SGD: 43 | (N/R)Adam(W): 136 | ... pt2: 216

These were..still...all slowdowns :/ Okay this is sus.

janeyx99 commented 1 year ago

Fix for why we only see slowdowns: https://github.com/pytorch/benchmark/pull/1621