Fix a test that is failing flakily on GPU

pytorch / botorch

Bayesian optimization in PyTorch

https://botorch.org/

MIT License

3.1k stars 404 forks source link

Fix a test that is failing flakily on GPU #2521

Closed esantorella closed 2 months ago

esantorella commented 2 months ago

Summary: This PR:

Updates the tolerance described below from 0.12 to 0.13
Adds a double-precision case to this test (doesn't make a difference)
Updates some checks to assertAllClose

Differential Revision: D62442905

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62442905

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.98%. Comparing base (167dcb7) to head (9a9f02b).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2521 +/- ## ======================================= Coverage 99.98% 99.98% ======================================= Files 193 193 Lines 16963 16963 ======================================= Hits 16961 16961 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62442905

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62442905

facebook-github-bot commented 2 months ago

This pull request has been merged in pytorch/botorch@4d49bf7c97b971c4d2149577a7c8f252531f4b7f.