search

pytorch / botorch

Bayesian optimization in PyTorch
https://botorch.org/
MIT License
3.11k stars 406 forks source link

Robustify prune_inferior_points tests against sorting order #2548

Closed Balandat closed 2 months ago

Balandat commented 2 months ago

Our nightly CI started failing, likely due to a sorting order change introduced in https://github.com/pytorch/pytorch/pull/127936

This change robustifies the tests against the point order (and also fixes a torch deprecation warning)

facebook-github-bot commented 2 months ago

@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D63260870

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D63260870

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D63260870

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.98%. Comparing base (ab5ffea) to head (f1ffb7e). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2548 +/- ## ======================================= Coverage 99.98% 99.98% ======================================= Files 193 193 Lines 17010 17056 +46 ======================================= + Hits 17007 17053 +46 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D63260870

facebook-github-bot commented 2 months ago

@Balandat merged this pull request in pytorch/botorch@ad9978fac775e1657bb4e5375d85e443913da25e.