search

pytorch / botorch

Bayesian optimization in PyTorch
https://botorch.org/
MIT License
3.11k stars 406 forks source link

Clean up settings.debug #2612

Closed saitcakmak closed 2 weeks ago

saitcakmak commented 2 weeks ago

Summary: In the past, settings.debug used to supress all BoTorchWarnings. Some time ago, we reduced its scope and started surfacing these warnings again. Since then, there are only a couple places where settings.debug is used. I was curious how much usage it had left and decided to clean it up completely while at it.

Differential Revision: D65498337

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65498337

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.98%. Comparing base (3ca48d0) to head (c0801bd). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2612 +/- ## ========================================== - Coverage 99.98% 99.98% -0.01% ========================================== Files 196 196 Lines 17372 17359 -13 ========================================== - Hits 17370 17357 -13 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65498337

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D65498337

facebook-github-bot commented 2 weeks ago

This pull request has been merged in pytorch/botorch@8b13120176a83080dc023cf85a1d33311e6e1cae.