search

pytorch / botorch

Bayesian optimization in PyTorch
https://botorch.org/
MIT License
3.11k stars 406 forks source link

Deduplicate shared logic in prune_inferior_points(_multi_objective) #2629

Closed saitcakmak closed 1 week ago

saitcakmak commented 1 week ago

Summary: There was a lot of repetition between these two methods. This diff extracts the shared parts into a helper method.

Also cleaned some pyre complains while at it.

Differential Revision: D66006629

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D66006629

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.98%. Comparing base (92d73e4) to head (c580e2a). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2629 +/- ## ========================================== - Coverage 99.98% 99.98% -0.01% ========================================== Files 196 196 Lines 17332 17298 -34 ========================================== - Hits 17330 17296 -34 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 1 week ago

This pull request has been merged in pytorch/botorch@3c2ce15ea2f0b24f0985ec83ed04b36188980f74.