pytorch / builder

Continuous builder and binary build scripts for pytorch
BSD 2-Clause "Simplified" License
328 stars 220 forks source link

Docker Images Validate. Fix arm64 docker builds to not contain cuda versions #1806

Open atalman opened 5 months ago

atalman commented 5 months ago

As continuation of work of: https://github.com/pytorch/builder/issues/1432

Following images needs to be validated with this option ON. Only applicable to Release channel

pytorch/pytorch:2.3.0-cuda12.1-cudnn8-runtime
pytorch/pytorch:2.3.0-cuda11.8-cudnn8-runtime
pytorch/pytorch:2.3.0-cuda12.1-cudnn8-devel
pytorch/pytorch:2.3.0-cuda11.8-cudnn8-devel

Instead if the ghcr.io images

ghcr.io/pytorch/pytorch:2.3.0-cuda12.1-cudnn8-runtime
ghcr.io/pytorch/pytorch:2.3.0-cuda11.8-cudnn8-runtime
ghcr.io/pytorch/pytorch:2.3.0-cuda12.1-cudnn8-devel
ghcr.io/pytorch/pytorch:2.3.0-cuda11.8-cudnn8-devel

cc @juliagmt-google

To be able to detect issues similar to this: https://github.com/pytorch/pytorch/issues/125094

Docker release matrix: https://github.com/pytorch/test-infra/blob/main/.github/workflows/generate_docker_release_matrix.yml

Python script https://github.com/pytorch/test-infra/blob/main/tools/scripts/generate_docker_release_matrix.py

Validate docker image: https://github.com/pytorch/builder/blob/main/.github/workflows/validate_docker_images.yml

atalman commented 4 months ago

Landed https://github.com/pytorch/pytorch/pull/125617 to fix issue 3. And synchronized with test-infra script: https://github.com/pytorch/test-infra/pull/5184