search

pytorch / builder

Continuous builder and binary build scripts for pytorch
BSD 2-Clause "Simplified" License
323 stars 213 forks source link

[BE] More code-reuse across tests #1869

Open atalman opened 2 weeks ago

atalman commented 2 weeks ago

Previous title: Enable check_binary for MacOS and Windows MacOS and Windows nightly builds are missing check_binary.sh step:

See reference issue: https://github.com/pytorch/pytorch/issues/120995

Linux builds has check_binary: https://github.com/pytorch/pytorch/actions/runs/9543726459/job/26305659019#step:17:308 However not macos or Windows. For faster development. We can try to enable check binary running on Validation tests here: https://github.com/pytorch/builder/blob/main/.github/scripts/validate_binaries.sh#L54

When successful we can later move it our CI

malfet commented 2 weeks ago

I think title of this issue is somewhat misleading, as check_binary is already invoked for MacOS builds: https://github.com/pytorch/pytorch/blob/0f89e66d1745b8f4b304ebf46174bc726f0c28f5/.circleci/scripts/binary_macos_test.sh#L30