search

pytorch / builder

Continuous builder and binary build scripts for pytorch
BSD 2-Clause "Simplified" License
328 stars 220 forks source link

add +PTX to CUDA 12.4 nightly binaries #1932

Closed ptrblck closed 2 months ago

ptrblck commented 2 months ago

This PR adds +PTX back to our x86 CUDA 12.4 binaries, which was previously dropped. We should consider adding this change only to nightly binaries and keep versioned releases as they are to keep the binary size lower. However, I'm unsure how and where the nightly builds are calling this script.

CC @malfet

atalman commented 2 months ago

@ptrblck what is the size increase for these binaries ?

ptrblck commented 2 months ago

CC @nWEIdia do you know what the approx. size increase for +PTX would be? I think you just recently measured it.

nWEIdia commented 2 months ago

CC @nWEIdia do you know what the approx. size increase for +PTX would be? I think you just recently measured it.

The approximate size increase for +PTX would be 200MB.

malfet commented 2 months ago

Let's give it a try, we can always rollback later