Closed chillerb closed 2 weeks ago
Hi @chillerb!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you. Please run ufmt format .
and update.
Got it, I run the formatter over example.py
.
@cyrjano has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Sorry for this, but I will need a couple of new updates. Please add typing to the forward function.
def forward(x:Tensor) -> Tensor
and sync to master there are a couple of fixes that should gives us a clean run.
Also there seems to be an import os
that is no longer needed from the failures`
@cyrjano has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@cyrjano merged this pull request in pytorch/captum@6540e74ee709b850280d0d5163b574e271d7b9c4.
Don't set environment variable
WERKZEUG_RUN_MAIN
Solution proposed by: @jeremyfix
With Werkzeug 2.1.0, setting the environment variable
WERKZEUG_RUN_MAIN
results inKeyError: 'WERKZEUG_SERVER_FD'
.WERKZEUG_RUN_MAIN
is used by Werkzeug internally and is not supposed to be set by external libraries. Therefore, I removedos.environ["WERKZEUG_RUN_MAIN"] = "true"
. As a side effect, the startup message is shown, but this shouldn't be a problem compared to theKeyError.
Related Issues:
Fix import and typing errors
In
example.py
, there were some import and typing errors. I also updated the example path in theREADME.md
.Testenvironment
OS: Debian 12 Python: Tested in both 3.11 and 3.12