pytorch / cppdocs

PyTorch C++ API Documentation
https://pytorch.org/cppdocs
208 stars 33 forks source link

installation link is dead. (Maybe typo) #1

Closed crcrpar closed 6 years ago

crcrpar commented 6 years ago

Hi,

In index.html (https://pytorch.org/cppdocs/frontend.html#installation), I couldn't jump to installation page and found that link is https://pytorch.org/cppdocs/installation.html not https://pytorch.org/cppdocs/installing.html.

goldsborough commented 6 years ago

Hey, thanks for catching this. We're currently fixing our download links. Please see this temporary markdown file I created with the correct download URLs: https://gist.github.com/goldsborough/fc3d94917f0405a9da7ec2899710eb9f.

I'll update the website ASAP.

crcrpar commented 6 years ago

I got it. Thanks!

perone commented 6 years ago

Is there any particular reason for the torch.h be inside the include/torch/csrc instead of inside of include/torch? The TorchConfig.cmake isn't adding the csrc into the include paths, only the torch directory. Thanks !

goldsborough commented 6 years ago

@perone do you have a recent download of libtorch? There's been some recent changes, but if you download a new libtorch distribution the TorchConfig.cmake should have these lines:

# Include directories.
if (EXISTS "${TORCH_INSTALL_PREFIX}/lib/include")
  set(TORCH_INCLUDE_DIRS
    ${TORCH_INSTALL_PREFIX}/lib/include
    ${TORCH_INSTALL_PREFIX}/lib/include/torch/csrc/api/include)
else()
  set(TORCH_INCLUDE_DIRS
    ${TORCH_INSTALL_PREFIX}/include
    ${TORCH_INSTALL_PREFIX}/include/torch/csrc/api/include)
endif()

which configures the correct include paths. There should also only be one torch.h, which is libtorch/include/torch/csrc/api/include/torch/torch.h. The one in torch/csrc/ was recently deleted.

Please let me know if this is not the case and we'll fix it.

perone commented 6 years ago

Thanks for the reply, I guess I have an old version then (I don't have this directory structure, and there is no torch.h inside the api/include/torch), I got it from this link (from the gist): https://download.pytorch.org/libtorch/nightly/cpu/libtorch-macos-latest.zip, is there any other place where I can find the recent binaries ?

goldsborough commented 6 years ago

No that's the correct link. There's something funny going on, the MacOS distribution seems to be out of date. The linux distribution is updated. I will have to talk to our release folks about this. That will likely have to wait until tomorrow though. I'll get back to you here as soon as I can. Maybe you can try out the linux distro in a docker image in the meantime.

perone commented 6 years ago

Oka, no problem, I can wait for it. Thanks a lot for the quick replies !

goldsborough commented 6 years ago

The mac build is now fixed. You can also use our website now to get the latest links: https://pytorch.org/get-started/locally/ Click on "LibTorch" and then "Mac" and "CPU" and it should show a nice link:

screen shot 2018-10-01 at 14 45 59
perone commented 6 years ago

That's amazing, thanks a lot @goldsborough !