search

pytorch / cpuinfo

CPU INFOrmation library (x86/x86-64/ARM/ARM64, Linux/Windows/Android/macOS/iOS)
BSD 2-Clause "Simplified" License
993 stars 314 forks source link

update configure.py #1

Closed ghost closed 6 years ago

Maratyszcza commented 6 years ago

It removes support of Android, 32-bit x86, and 32-bit ARM. Why?

ghost commented 6 years ago

Sorry, I made a mistake! I wanted to update the cpuinfo version I forked from your repo with the latest changes you've made. I looked for some button to synchronize and pushed 'pull request' as I thought it will do the trick. I'm still not fully at ease with github.

ghost commented 6 years ago

If removed build.target.is_x86 and build.target.is_android because I was getting an error saying: Platform instance has no attribute "is_x86" when I launched python ./configure.py after calling confu setup. I don't know how to delete or cancel this "pull request" if that should be necessary.

Maratyszcza commented 6 years ago

Thats fine. You may need to update confu to get around no-is_x86-attribute problem. Alternatively, you may use CMake to build cpuinfo.

ghost commented 6 years ago

Thanks for the info. After updating confu all problems where solved!