pytorch / cpuinfo

CPU INFOrmation library (x86/x86-64/ARM/ARM64, Linux/Windows/Android/macOS/iOS)
BSD 2-Clause "Simplified" License
992 stars 311 forks source link

Add support for Arm FHM #102

Closed kulinseth closed 2 years ago

kulinseth commented 2 years ago

@malfet ping for review.

kulinseth commented 2 years ago

@pytorchbot rebase

kulinseth commented 2 years ago

@Maratyszcza addressed your comments. Thanks.

kulinseth commented 2 years ago

@malfet ,

/home/runner/work/cpuinfo/cpuinfo/src/arm/linux/cpuinfo.c:291:29: error: use of undeclared identifier 'CPUINFO_ARM_LINUX_FEATURE_ASIMDFHM'
[86](https://github.com/pytorch/cpuinfo/runs/7395025124?check_suite_focus=true#step:6:87)
                                        processor->features |= CPUINFO_ARM_LINUX_FEATURE_ASIMDFHM;
[87](https://github.com/pytorch/cpuinfo/runs/7395025124?check_suite_focus=true#step:6:88)
                                                               ^
[88](https://github.com/pytorch/cpuinfo/runs/7395025124?check_suite_focus=true#step:6:89)
1 error generated.
[89](https://github.com/pytorch/cpuinfo/runs/7395025124?check_suite_focus=true#step:6:90)
[7/239] Building C object CMakeFiles/cpuinfo.dir/src/arm/linux/init.c.o
[90](https://github.com/pytorch/cpuinfo/runs/7395025124?check_suite_focus=true#step:6:91)
ninja: build stopped: subcommand failed.
[91](https://github.com/pytorch/cpuinfo/runs/7395025124?check_suite_focus=true#step:6:92)
Error: Process completed with exit code 1.

This looks like genuine failure. Do we need to make this Mac arm specific ?

Maratyszcza commented 2 years ago

Fails on AArch32 because identifier is only defined on AArch64

kulinseth commented 2 years ago

Fails on AArch32 because identifier is only defined on AArch64

Thanks, removed that line.