Open iskunk opened 7 months ago
Hi @iskunk!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Updated after confirming that the source-download path can also link against GTest::gtest
and the like, thus rendering unnecessary the *_LIB
variables.
Also confirmed that the INCLUDE_DIRECTORIES()
directives are not needed.
I have my own builds of the GTest and benchmark libraries that I want to use in the cpuinfo build, but the
USE_SYSTEM_LIBS
option assumes that these are installed in the default compiler/linker paths, without allowing for an alternate location (e.g. somewhere under$HOME
or/opt
).This patch enables the standard
*_ROOT
convention supported byfind_package()
for these libraries, i.e.-DGTest_ROOT=/path/to/gtest-prefix
and-Dbenchmark_ROOT=/path/to/benchmark-prefix
.