search

pytorch / cpuinfo

CPU INFOrmation library (x86/x86-64/ARM/ARM64, Linux/Windows/Android/macOS/iOS)
BSD 2-Clause "Simplified" License
962 stars 306 forks source link

Fix chipset enum name to include 'vendor_' #210

Closed prashanthswami closed 7 months ago

prashanthswami commented 7 months ago

The original change that introduced this should have used a consistent prefix for all enum types, for consistency sake.

prashanthswami commented 7 months ago

Review: @malfet

malfet commented 7 months ago

@prashanthswami can you please stop pinging me for reviews. This project at the moment needs a maintainer and I'm not sure I have a proper bandwith to be one (if I one, I should not have let original riscV change in without proper testing on my end, but I have not setup my riscv board yet)

prashanthswami commented 7 months ago

@malfet Understood - I apologize for the frequent review requests, I'll pause going forward. I'm trying to understand what the next steps are here though, is there a set of people looking for a new maintainer? Can I follow along somehow to be informed if a maintainer has been selected, or if I find someone who's interested, can they offer to help maintain this library through some process? (Is that the Pytorch discussion forums?)

malfet commented 7 months ago

@prashanthswami discussion forum or Slack (did you join) sounds like a good venue. And yes, volunteers sounds great, but I would like them to be a seasoned contributor

prashanthswami commented 7 months ago

Haven't gotten an invite yet, but did submit the form (and got confirmation the form was submitted), would you be able to help loop me in there? I'll ask around with some folks who've worked on this library internally to see if they can help provide support here.