Closed everton1984 closed 3 months ago
@Maratyszcza Sorry to ping here, is there something I need to do to get this reviewed? Like creating a Issue or something?
I no longer maintain this project, defer to @malfet
@malfet Any chance you could take a look at this please?
@everton1984 please fix clang-formatting, otherwise LGTM
@everton1984 please fix clang-formatting, otherwise LGTM
@malfet Done. Hopefully it worked. Thanks a lot for reviewing!
@malfet , @everton1984 ;
First of all, thanks for the contribution.
However, we are considering that this PR is causing an issue for detection Ampere(R) Altra(R) Processor
.
Thus, we created an issue with the details and a possible solution with PR.
This MR includes support for building with Bazel on cpu
arm64_windows
, I also tried this on my Volterra Windows Dev Kit and noticed that the core string seems different from what the current source code defines. I don't know if this is because my hardware is a bit different or not.I ran the tests with the following results
with
cpu-info.exe
returningand
isa-info.exe
returning