Closed mingfeima closed 3 months ago
@malfet @xuhancn @jgong5 could you please help review this one ? thx!
The indentation looks problematic (guess tab vs. space). Others LGTM.
Fixed!
Overall LGTM, but let's add a separator for those names to match how it's done for AVX512.
Another question: are there CPUs on the market that say has fp16 but not int8 AMX support?
Would be good to add a much more details description with links back to the docs explaning what those extensions do and what CPUs support them
Currently we do not have platforms that supports amx-fp16
but not amx-int8
.
I put a note in before the amx detection functions:
/* [NOTE] Intel Advanced Matrix Extensions (AMX) detection
*
* I. AMX is a new extensions to the x86 ISA to work on matrices, consists of
* 1) 2-dimentional registers (tiles), hold sub-matrices from larger matrices in memory
* 2) Accelerator called Tile Matrix Multiply (TMUL), contains instructions operating on tiles
*
* II. Platforms that supports AMX:
* +-----------------+-----+----------+----------+----------+----------+
* | Platforms | Gen | amx-bf16 | amx-tile | amx-int8 | amx-fp16 |
* +-----------------+-----+----------+----------+----------+----------+
* | Sapphire Rapids | 4th | YES | YES | YES | NO |
* +-----------------+-----+----------+----------+----------+----------+
* | Emerald Rapids | 5th | YES | YES | YES | NO |
* +-----------------+-----+----------+----------+----------+----------+
* | Granite Rapids | 6th | YES | YES | YES | YES |
* +-----------------+-----+----------+----------+----------+----------+
*
* Reference: https://www.intel.com/content/www/us/en/products/docs
* /accelerator-engines/advanced-matrix-extensions/overview.html
@malfet If you find a better place to put this note, please let me know!
Tested using intel SDE: https://www.intel.com/content/www/us/en/download/684897/intel-software-development-emulator.html
Test scripts:
Results: