search

pytorch / cpuinfo

CPU INFOrmation library (x86/x86-64/ARM/ARM64, Linux/Windows/Android/macOS/iOS)
BSD 2-Clause "Simplified" License
996 stars 314 forks source link

add detection for intel new isa: avx_ne_convert, avx_vnni_int8, avx_vnni_int16 #232

Closed mingfeima closed 5 months ago

mingfeima commented 6 months ago

Test Plan:

bash scripts/local-build.sh

ISAS=()
OPTIONS=()
PLATFORMS=()

OPTIONS+=(-quark); PLATFORMS+=("Quark")
OPTIONS+=(-p4); PLATFORMS+=("Pentium4")
OPTIONS+=(-p4p); PLATFORMS+=("Pentium4 Prescott")
OPTIONS+=(-mrm); PLATFORMS+=("Merom")
OPTIONS+=(-pnr); PLATFORMS+=("Penryn")
OPTIONS+=(-nhm); PLATFORMS+=("Nehalem")
OPTIONS+=(-wsm); PLATFORMS+=("Westmere")
OPTIONS+=(-snb); PLATFORMS+=("Sandy Bridge")
OPTIONS+=(-ivb); PLATFORMS+=("Ivy Bridge")
OPTIONS+=(-hsw); PLATFORMS+=("Haswell")
OPTIONS+=(-bdw); PLATFORMS+=("Broadwell")
OPTIONS+=(-slt); PLATFORMS+=("Saltwell")
OPTIONS+=(-slm); PLATFORMS+=("Silvermont")
OPTIONS+=(-glm); PLATFORMS+=("Goldmont")
OPTIONS+=(-glp); PLATFORMS+=("Goldmont Plus")
OPTIONS+=(-tnt); PLATFORMS+=("Tremont")
OPTIONS+=(-snr); PLATFORMS+=("Snow Ridge")
OPTIONS+=(-skl); PLATFORMS+=("Skylake")
OPTIONS+=(-cnl); PLATFORMS+=("Cannon Lake")
OPTIONS+=(-icl); PLATFORMS+=("Ice Lake")
OPTIONS+=(-skx); PLATFORMS+=("Skylake server")
OPTIONS+=(-clx); PLATFORMS+=("Cascade Lake")
OPTIONS+=(-cpx); PLATFORMS+=("Cooper Lake")
OPTIONS+=(-icx); PLATFORMS+=("Ice Lake server")
OPTIONS+=(-knl); PLATFORMS+=("Knights landing")
OPTIONS+=(-knm); PLATFORMS+=("Knights mill")
OPTIONS+=(-tgl); PLATFORMS+=("Tiger Lake")
OPTIONS+=(-adl); PLATFORMS+=("Alder Lake")
OPTIONS+=(-mtl); PLATFORMS+=("Meteor Lake")
OPTIONS+=(-rpl); PLATFORMS+=("Raptor Lake")
OPTIONS+=(-spr); PLATFORMS+=("Sapphire Rapids")
OPTIONS+=(-gnr); PLATFORMS+=("Granite Rapids")
OPTIONS+=(-gnr256); PLATFORMS+=("Granite Rapids (AVX10.1 / 256VL)")
OPTIONS+=(-srf); PLATFORMS+=("Sierra Forest")
OPTIONS+=(-arl); PLATFORMS+=("Arrow Lake")
OPTIONS+=(-lnl); PLATFORMS+=("Lunar Lake")
OPTIONS+=(-future); PLATFORMS+=("Future chip")

ISAS+=("AVX_VNNI_INT8")
ISAS+=("AVX_VNNI_INT16")
ISAS+=("AVX_NE_CONVERT")

SDE_BIN="/home/mingfeim/packages/sde-external-9.33.0-2024-01-07-lin/sde"

for I in "${!PLATFORMS[@]}"; do
  echo "${PLATFORMS["${I}"]}"
    for J in "${!ISAS[@]}"; do
      "${SDE_BIN}" "${OPTIONS[$I]}" -- ./build/local/isa-info | grep ${ISAS[$J]}
    done
done

Results:

Quark
SDE-ERROR: 64 bits applications are not supported by input chip: PENTIUM or by the input cpuid definition file
SDE-ERROR: 64 bits applications are not supported by input chip: PENTIUM or by the input cpuid definition file
SDE-ERROR: 64 bits applications are not supported by input chip: PENTIUM or by the input cpuid definition file
Pentium4
SDE-ERROR: 64 bits applications are not supported by input chip: PENTIUM4 or by the input cpuid definition file
SDE-ERROR: 64 bits applications are not supported by input chip: PENTIUM4 or by the input cpuid definition file
SDE-ERROR: 64 bits applications are not supported by input chip: PENTIUM4 or by the input cpuid definition file
Pentium4 Prescott
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Merom
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Penryn
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Nehalem
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Westmere
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Sandy Bridge
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Ivy Bridge
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Haswell
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Broadwell
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Saltwell
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Silvermont
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Goldmont
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Goldmont Plus
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Tremont
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Snow Ridge
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Skylake
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Cannon Lake
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Ice Lake
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Skylake server
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Cascade Lake
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Cooper Lake
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Ice Lake server
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Knights landing
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Knights mill
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Tiger Lake
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Alder Lake
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Meteor Lake
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Raptor Lake
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Sapphire Rapids
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Granite Rapids
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Granite Rapids (AVX10.1 / 256VL)
        AVX_VNNI_INT8: no
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: no
Sierra Forest
        AVX_VNNI_INT8: yes
        AVX_VNNI_INT16: no
        AVX_NE_CONVERT: yes
Arrow Lake
        AVX_VNNI_INT8: yes
        AVX_VNNI_INT16: yes
        AVX_NE_CONVERT: yes
Lunar Lake
        AVX_VNNI_INT8: yes
        AVX_VNNI_INT16: yes
        AVX_NE_CONVERT: yes
Future chip
        AVX_VNNI_INT8: yes
        AVX_VNNI_INT16: yes
        AVX_NE_CONVERT: yes
fbarchard commented 6 months ago

test plan should include emerald rapids

mingfeima commented 6 months ago

test plan should include emerald rapids

EMR (Emerald Rapids) has the same ISA as SPR (Sapphire Rapids).

fbarchard commented 6 months ago

ok, but intel sde does support -emr so it wouldnt hurt to test it.

mingfeima commented 6 months ago

Sure，will add this -emr in future pull requests!

mingfeima commented 5 months ago

@malfet could you please help review this one? once this one is settled, we will proceed to replace the amx and avx-vnni-int8 checks from onednn to cpuinfo in pytorch aten.

malfet commented 5 months ago

@mingfeima LGTM, though I'm a bit concerned about number of options we are adding and whether devs will be able to affectively use it

mingfeima commented 5 months ago

@malfet the format issue has been fixed, please review again! thanks!