Closed ozanMSFT closed 5 months ago
Hi @ozanMSFT!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@ozanMSFT Thanks for the update, sorry as I had no other hardware to test. The changes look fair.
Summary:
Resolves #236
Also related to PR 220 change.
Previous error details:
The error's reason was:
woa_chip_name
(windows-arm-init.h
) enum had only 4 elements (stored inwoa_chip_name_last
)However,
woa_chips[]
(init.c
) has a duplicated value forwoa_chip_name_microsoft_sq_3
due to different strings for same target after the PR 220And this was causing following
for loop
(init.c
) is not checking for all elements inwoa_chips[]
.Fix Details:
We added
woa_chip_name_microsoft_sq_3_devkit
to maintain one to one relationship betweenwoa_chip_name
(windows-arm-init.h
) andwoa_chips[]
(init.c
).Also, we especially specified indexes with
enums
to prevent future duplications and increase readability of the code and relationship.