search

pytorch / cpuinfo

CPU INFOrmation library (x86/x86-64/ARM/ARM64, Linux/Windows/Android/macOS/iOS)
BSD 2-Clause "Simplified" License
993 stars 313 forks source link

Use PROJECT_* instead of CMAKE_* and specify the binary output dir of clog #32

Open xuhdev opened 4 years ago

xuhdev commented 4 years ago

To improve the compatiblity when used as a subproject.

xuhdev commented 4 years ago

To ensure PyTorch's compatibility, please wait until https://github.com/pytorch/pytorch/pull/33922 is merged.

xuhdev commented 4 years ago

pytorch/pytorch#33922 has been merged now.

soumith commented 4 years ago

@Maratyszcza can you review

facebook-github-bot commented 3 years ago

Hi @xuhdev!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!