Closed Developer-Ecosystem-Engineering closed 2 years ago
Hi @Developer-Ecosystem-Engineering!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!
Closing as duplicated in #96
The description of this PR mentions:
Updated package.name to also query machdep.cpu.brand_string if decode of hw.machine fails
But then that functionality was omitted (inadvertently?) in its refactoring in #100. I've added it back in #246.
The patch applies to ARM and should not change any behavior for x86_64 / Intel. In general, it'll use newer sysctls when they're available, but fallback to previous implementations when they're not present. Newer sysctls are available in iOS 15 and macOS Monterey 12.
Example output:
Previous cpu-info running on macOS / M1:
cpu-info running on macOS / M1 after patch:
Previous isa-info running on macOS / M1:
isa-info running on macOS Monterey 12 / M1 after patch:
Previous cache-info running on macOS / M1:
cache-info running on macOS Monterey 12 / M1 after patch: