Enable new win-arm64 platform

pytorch / cpuinfo

CPU INFOrmation library (x86/x86-64/ARM/ARM64, Linux/Windows/Android/macOS/iOS)

BSD 2-Clause "Simplified" License

992 stars 311 forks source link

Enable new win-arm64 platform #82

Closed gaborkertesz-linaro closed 2 years ago

gaborkertesz-linaro commented 2 years ago

This PR enables the new Windows on Arm (win-arm64) platform, by implementing the required APIs, reading topology information via Windows API.

gaborkertesz-linaro commented 2 years ago

_win-arm64_cmake-config.log _win-arm64_cmake-build.log _win-arm64_init-test.log _win-arm64_cache-info.log _win-arm64_cpu-info.log _win-arm64_isa-info.log

gaborkertesz-linaro commented 2 years ago

Build on win-arm64 cmake . -G "Visual Studio 16 2019" -A ARM64 cmake --build .

gaborkertesz-linaro commented 2 years ago

@malfet Could you review it? Thanks!

gaborkertesz-linaro commented 2 years ago

@malfet Can I do anything else to close this and the related PR?

strega-nil-ms commented 2 years ago

any updates on this?

gaborkertesz-linaro commented 2 years ago

any updates on this?

Not on my side, but I'd happily close this!

niyas-sait commented 2 years ago

Can this be merged, please?

kalaskarsanket commented 2 years ago

Any plans on merging this PR ?

niyas-sait commented 2 years ago

(@gaborkertesz-linaro is on holiday now and planning to address the comments in couple of weeks)

gaborkertesz-linaro commented 2 years ago

I hope I've fixed all of your findings, please let me know if I missed any of them! Unfortunetaly I wasn't able to setup building with LLVM by CMake, but I've built with '-Wall' by MSVC compiler.

kaadam commented 2 years ago

I hope I've fixed all of your findings, please let me know if I missed any of them! Unfortunetaly I wasn't able to setup building with LLVM by CMake, but I've built with '-Wall' by MSVC compiler.

Gabor, thanks for updating it. Checking on my side, I get back to you asap.

gaborkertesz-linaro commented 2 years ago

@malfet What do you think?