Fix two types of issues raised by mypy - implicit optional issues and arg-type mismatch

pytorch / data

A PyTorch repo for data loading and utilities to be shared by the PyTorch domain libraries.

BSD 3-Clause "New" or "Revised" License

1.08k stars 142 forks source link

Fix two types of issues raised by mypy - implicit optional issues and arg-type mismatch #1234

Closed gokulavasan closed 3 months ago

gokulavasan commented 3 months ago

Title. Here is the mypy run failing with 24 errors - https://github.com/pytorch/data/actions/runs/8428471909/job/23081016202.

With these two changes, the mypy errors are now down to 8 - https://github.com/pytorch/data/actions/runs/8428898766/job/23082258705?pr=1234

Changes

Add optional where it was implicit earlier
Change ignore type to arg-type

gokulavasan commented 3 months ago

@ejguan Yes I am trying to fix all the errors. Got it down from 24 to 8. When I run the local command that you provided above, I am getting 11 errors. I will try and get to the remaining 8 in a separate PR as they warrant a bit more debugging

andrewkho commented 3 months ago

LGTM but noob q: where can we see that the errors decreased?

gokulavasan commented 3 months ago

@andrewkho For the decrease in errors, check the two links in the summary post. Also for the latest CI run, you can look at the CI run status in the "Review Requested" section

facebook-github-bot commented 3 months ago

@gokulavasan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@gokulavasan merged this pull request in pytorch/data@2b831b38939705c239dfcb064c6c61c8443ed3e9.