search

pytorch / data

A PyTorch repo for data loading and utilities to be shared by the PyTorch domain libraries.
BSD 3-Clause "New" or "Revised" License
1.08k stars 142 forks source link

Add an additional test for fast-state-dict request problem when snapshot_every_n_steps > 1 #1252

Closed andrewkho closed 1 month ago

andrewkho commented 1 month ago

1251 <- See this PR for more context on the bug. Adds an additional test to check that this still works when snapshot_every_n_steps > 1

Changes

andrewkho commented 1 month ago

MacOS tests are failing during shutdown still, it's intermittent which is really annoying

facebook-github-bot commented 1 month ago

@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@andrewkho merged this pull request in pytorch/data@4e70d267894ba7e470a9220bec8ccebd158eac92.