Incremental state: fix flatten None handling

pytorch / data

A PyTorch repo for data loading and utilities to be shared by the PyTorch domain libraries.

BSD 3-Clause "New" or "Revised" License

1.08k stars 142 forks source link

Incremental state: fix flatten None handling #1266

Closed gokulavasan closed 1 month ago

gokulavasan commented 1 month ago

Flatten could return None but result of flatten was recursively used for updating the flatten map. This caused an error when the value of the dict is None. Handling that case now and also added unit tests to capture that scenario

Fixes #{issue number}

Changes

-

pytorch-bot[bot] commented 1 month ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1266

:page_facing_up: Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit ec83a1a996733173961b266579529f78b7a5c8cf with merge base 2d7021975b13220d2eab4fa1a1e211cfcb8fa8e6 (): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 1 month ago

@gokulavasan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@gokulavasan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@gokulavasan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.