pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
1.35k stars 218 forks source link

Arm backend batchnorm2d fixes and tests #3369

Closed zingo closed 3 weeks ago

zingo commented 1 month ago

Batchnorm2d did not handle weight and bias

pytorch-bot[bot] commented 1 month ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3369

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (1 Unrelated Failure)

As of commit d856b1ca1546af7f5d37cd4d0dd2a481d0465615 with merge base 3df8695a8816b9002a9b2dade33ef73629b919c1 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

* [trunk / test-coreml-delegate / macos-job](https://hud.pytorch.org/pr/pytorch/executorch/3369#24637209590) ([gh](https://github.com/pytorch/executorch/actions/runs/8971447647/job/24637209590)) ([trunk failure](https://hud.pytorch.org/pytorch/executorch/commit/3df8695a8816b9002a9b2dade33ef73629b919c1#24615250611)) `RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] commented 1 month ago

Please seek CI approval before scheduling CIFlow labels

zingo commented 1 month ago

@pytorchbot label ciflow/trunk

pytorch-bot[bot] commented 1 month ago

Can't add following labels to PR: ciflow/trunk. Please ping one of the reviewers for help.

zingo commented 1 month ago

@pytorchbot label ciflow/trunk

facebook-github-bot commented 1 month ago

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

zingo commented 3 weeks ago

I see this is "imported" anything more you want me to do or should I just wait :)

digantdesai commented 3 weeks ago

Rebase please?

facebook-github-bot commented 3 weeks ago

@digantdesai merged this pull request in pytorch/executorch@a82db7c05e759cd6b7a8a3a9d0e2377eaf840e41.

zingo commented 3 weeks ago

Sorry didn't have time to look into this patch today.

zingo commented 2 weeks ago

Some comments fixed in https://github.com/pytorch/executorch/pull/3658