pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
1.31k stars 206 forks source link

Build pybindings with -D_GLIBCXX_USE_CXX11_ABI=0 to match libtorch.so #3471

Closed dbort closed 2 weeks ago

dbort commented 2 weeks ago

Stack from ghstack (oldest at bottom):

libtorch.so builds with the old glibc ABI, so we need to as well, for any source files that include torch headers.

Differential Revision: D56857493

pytorch-bot[bot] commented 2 weeks ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3471

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 1bddaeed2212ac1927d4d50114fbd0a0f52876b5 with merge base 5d2a17b29f57ab77f0481ca1d96d827e610dc4bf (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

dbort commented 2 weeks ago

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

@dbort merged this pull request in pytorch/executorch@61d7af734ca2159e8133d60e4074a569b4f62dc0.