search

pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
1.31k stars 206 forks source link

Disable wheel delocation on macos #3473

Closed dbort closed 2 weeks ago

dbort commented 2 weeks ago

Stack from ghstack (oldest at bottom):

The executorch build system will ensure that .dylib/.so files have LC_LOAD_DYLIB and LC_RPATH entries that will work when they're installed.

Delocating (i.e., making copies of the .dylibs that ET's libs depend on) will break any libs that depend on the torch libraries if users ever import both torch and the executorch library. Both import paths must load exactly the same file, not just a copy of it.

Differential Revision: D56857483

pytorch-bot[bot] commented 2 weeks ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3473

Note: Links to docs will display an error until the docs builds have been completed.

:x: 1 New Failure

As of commit d8456f38e696830fceaf968180d60757c19a7ad2 with merge base 5d2a17b29f57ab77f0481ca1d96d827e610dc4bf (image):

NEW FAILURE - The following job has failed:

* [Build M1 Wheels / pytorch/executorch / upload / wheel-py3_8-cpu](https://hud.pytorch.org/pr/pytorch/executorch/3473#24487099754) ([gh](https://github.com/pytorch/executorch/actions/runs/8916101306/job/24487099754)) `Unable to find any artifacts for the associated workflow`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

dbort commented 2 weeks ago

@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

@dbort merged this pull request in pytorch/executorch@904b50c6fe9d6c1ddedafbea118ad2b8d77b775f.