Resolve compiler_flags to allow Mac build

pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch

https://pytorch.org/executorch/

Other

1.31k stars 206 forks source link

Resolve compiler_flags to allow Mac build #3478

Closed jorgep31415 closed 2 weeks ago

jorgep31415 commented 2 weeks ago

`-Wglobal-constructors`

In ET-Vulkan, we use global constructors without global destructors.

Example: auto cls = VulkanBackend();

xplat/executorch/backends/vulkan/runtime/VulkanBackend.cpp:511:6: error: declaration requires a global destructor [-Werror,-Wglobal-constructors]
auto cls = VulkanBackend();
     ^

On Mac, this results in a -Wglobal-constructors warning, which is disabled in this change.

`-Wmissing-prototypes`

`-Wshadow`

Same as https://github.com/pytorch/pytorch/pull/125361

Differential Revision: D56860764

pytorch-bot[bot] commented 2 weeks ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3478

:page_facing_up: Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit fcc6214346f5ab51856c9275a9e2783e91ea3c68 with merge base 3a253e96baa89e5a5434e91a236df63d54e0949e (): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D56860764

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D56860764

facebook-github-bot commented 2 weeks ago

This pull request has been merged in pytorch/executorch@4bd45c39a147f88748a19028593108e93e963474.