search

pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
1.39k stars 228 forks source link

don't partition max pool with ceil mode #3578

Closed mcr229 closed 1 month ago

mcr229 commented 1 month ago

Summary: XNNPACK doesn't support max pooling with ceil mode, so we should not be partitioning these nodes where ceil mode is True

Resolving this issue: https://github.com/pytorch/executorch/issues/3567

Differential Revision: D57228128

pytorch-bot[bot] commented 1 month ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3578

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 3bc9fddef5f9d3e9ee0deccae2fd3eff8b8db994 with merge base b93b7ae4ad00ac15ab5ade347fa0d2ce5756e32e (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D57228128

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D57228128

facebook-github-bot commented 1 month ago

This pull request has been merged in pytorch/executorch@87d828aabe88fd40e33fc82e03a063aec6f0b4fc.