checking "transposed convolution" at beginning

copyrightly commented 2 weeks ago

Summary: Current check_convolution_args checks shapes of parameters before checking transposed. For a model using ConvTranspose2d, this may incur error like

executorch:tensor_util.h:655] Check failed (a.size(dim_a) == b.size(dim_b)): Tensors do not match: a.size(0) = 512 does not match b.size(0) = 1024

instead of showing "transposed convolution not supported yet." (see "ET CPU" in the test plan of D57258810).

The reason for getting the error above is due to the difference of shape of weight between ConvTranspose2d and Conv2d, specifically,

shape of weight in ConvTranspose2d is (note that the first item is in_channels)
```
(in_channels, out_channels/groups, kernel_size[0], kernel_size[1])
```
instead, shape of weight in Conv2d is (note that the first item is out_channels)
```
(out_channels, in_channels/groups, kernel_size[0], kernel_size[1])
```
so tensors_have_same_size_at_dims(bias.value(), 0, weight, 0)); may fail for ConvTranspose2d.

The error message would be more informative if we check transposed at the beginning.

Differential Revision: D57424572

pytorch-bot[bot] commented 2 weeks ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3631

:page_facing_up: Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (1 Unrelated Failure)

As of commit 3e3a6b8b4bd2c1d9f32522ddb9c32fd444ff608d with merge base ad419a512b09a88f2b1f5d5f528693d60f084192 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

* [pull / unittest / macos (buck2) / macos-job](https://hud.pytorch.org/pr/pytorch/executorch/3631#25035238245) ([gh](https://github.com/pytorch/executorch/actions/runs/9107040500/job/25035238245)) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D57424572

facebook-github-bot commented 2 weeks ago

This pull request was exported from Phabricator. Differential Revision: D57424572

pytorch / executorch