search

pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
1.39k stars 228 forks source link

Use c++17 for OSS gtest #3654

Closed kirklandsign closed 1 month ago

kirklandsign commented 1 month ago

Some test code uses c++17 feature (inline static member)

Test Plan: CI. sh test/run_oss_cpp_tests.sh

pytorch-bot[bot] commented 1 month ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3654

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit edf03374cb0b79b3836a29a23ca10c23313a21ef with merge base 6efe44ce534ecdfbed6807500612e305445e3f3b (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 1 month ago

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@kirklandsign merged this pull request in pytorch/executorch@ae311b4825490110bd12c6847d34ce882c78028c.