Add ETDumpGen_Done state and reset when in that state

pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch

https://pytorch.org/executorch/

Other

1.35k stars 218 forks source link

Add ETDumpGen_Done state and reset when in that state #3667

Closed tarun292 closed 1 week ago

tarun292 commented 2 weeks ago

Summary: Currently when we call get_etdump_data() we finalize the flatbuffer and close it. In order to add entries to etdump once again after we've closed it we need to reset the etdump buffer.

In order to support this, adding a ETDumpGen_Done state to which we move after calling get_etdump_data(). When this state is detected in create_event_block we implicitly call reset() and thus enabling writing to the flatbuffer again without any user intervention.

Differential Revision: D57517927

pytorch-bot[bot] commented 2 weeks ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3667

:page_facing_up: Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit 5a4a5bd09b65088d630580ddba9030bb834db166 with merge base 47a29a13f4f2574b6787be03249633d5531b795a (): :green_heart: Looks good so far! There are no failures yet. :green_heart: