pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
1.41k stars 230 forks source link

use _to_copy or _to_dim_order_copy in I64toI32 pass #3968

Closed nathanaelsee closed 1 week ago

nathanaelsee commented 1 week ago

Summary: When converting an ExportedProgram to EdgeProgramManager via to_edge, _to_dim_order_copy or _to_copy will be used depending on the passed EdgeCompileConfig having _skip_dim_order set to true or false. For example:

compile_config=EdgeCompileConfig(
    _check_ir_validity=False,
    _skip_dim_order=True,
),

The newer _to_dim_order_copy op was added in D53747744/https://github.com/pytorch/executorch/pull/1970.

Adding a param to the pass init to determine if we use the newer op or not.

Differential Revision: D58395616

pytorch-bot[bot] commented 1 week ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3968

Note: Links to docs will display an error until the docs builds have been completed.

:hourglass_flowing_sand: No Failures, 1 Pending

As of commit bd3ead3af5a55a18bdae58f654861216a4da1c0a with merge base 22b063d7722d0182bf7fcf36e8896d6c0b241953 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D58395616

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D58395616

facebook-github-bot commented 1 week ago

This pull request was exported from Phabricator. Differential Revision: D58395616

facebook-github-bot commented 1 week ago

This pull request has been merged in pytorch/executorch@4cf9a46c45baa3daae7473e9b7a9a1c253e64e75.