Open zingo opened 1 week ago
Note: Links to docs will display an error until the docs builds have been completed.
There are 1 currently active SEVs. If your PR is affected, please view them below:
As of commit e7d615f82adb8095eaf2a08fd6c252eeae43519c with merge base 270d0558cecba173f5bc5a667124a79c6258054a (): :green_heart: Looks good so far! There are no failures yet. :green_heart:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
Hi @digantdesai this changes files outside Arm folders and need Meta review
lgtm, but @digantdesai should have a look as well
@pytorchbot label "topic: not user facing"
Love it. One consideration though, we should try to set this scripts such a way that not just a CI but a human (or a tutorial doc) can use this directly without any changes.
This way there is only one source of truth.
Stamping it to unblock you.
The plan was to make it easy to run. So we can use it in our CI also and other tests. We can describe them in the readme, at least the test script. Do you want the script to move out of the .ci Folders and placed under backend/arm/test or similar place in that in that case?
Do you want the script to move out of the .ci Folders and placed under backend/arm/test or similar place in that in that case?
I don't have a strong preference on where the script lives, as long as a user can just run it on a shell without hacking it up would be a nice-to-have, esp for Tutorial where we can point and know it will work because it is tested by CI.
This will run some more models in the github test flow and also enable some unit tests to use Corston3x0 FVP.
This structure up the Arm backend testing into separate runable scripts in the same structure as other backends.