Fix erroneous `extension_features` initialization

pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch

https://pytorch.org/executorch/

Other

2.2k stars 368 forks source link

Fix erroneous `extension_features` initialization #6936

Closed SS-JIA closed 3 days ago

SS-JIA commented 3 days ago

Summary:

Context

Some devices were hanging when trying to run Vulkan due to a bug in https://github.com/pytorch/executorch/pull/6910.

The issue is that extension_features was being initialized with &shader_float16_int8_types before shader_float16_int8_types was initialized.

Changes

This diff fixes the bug and changes extension_features to set to an appropriate value based on which extensions are available according to the vulkan headers being used.

Differential Revision: D66118505

pytorch-bot[bot] commented 3 days ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6936

:page_facing_up: Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

:white_check_mark: No Failures

As of commit c5fb97977d16cc902dc71240a1d84e7b51359b44 with merge base ee74d0613079efd094a6b2bd9d632f6b8d3556a5 (): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 3 days ago

This pull request was exported from Phabricator. Differential Revision: D66118505