pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
2.2k stars 368 forks source link

Fix compilation crash on iOS<16 #7007

Open f-meloni opened 20 hours ago

f-meloni commented 20 hours ago

Summary: Added conditional compilation to mitigate a crash on iOS<16 where the used function is not present. Fixes https://github.com/pytorch/executorch/issues/6984

Bonus: report back the error in case of compilation errors, which was missing

Differential Revision: D66294248

pytorch-bot[bot] commented 20 hours ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7007

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

:white_check_mark: No Failures

As of commit 8f75eefe45d735169da98adb2c2e48da1b5d8e76 with merge base 270d0558cecba173f5bc5a667124a79c6258054a (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 20 hours ago

This pull request was exported from Phabricator. Differential Revision: D66294248

f-meloni commented 18 hours ago

@pytorchbot label "module: coreml"

f-meloni commented 18 hours ago

@pytorchbot label "release notes: backends"