pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
2.2k stars 368 forks source link

[ET-VK] Rearranging code in permute op shader to reduce heavy math ops and improve performance. #7014

Open trivedivivek opened 13 hours ago

trivedivivek commented 13 hours ago

Stack from ghstack (oldest at bottom):

The diff rearranges Permute op shader code in executorch vulkan backend to reduce heavy math operations and improve performance. The change also include adding an extension to support explicit arithmetic types and changing the data type of the position variable to u16vec3.

Differential Revision: D66174765

pytorch-bot[bot] commented 13 hours ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7014

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

:x: 1 New Failure

As of commit c4bb212e0f6171926d126fcab456e4b0cfdf6bb8 with merge base 7375cf5ac9c01bb1e4798a4ee4bdbdb5dfccfb0d (image):

NEW FAILURE - The following job has failed:

* [Check Labels / Check labels](https://hud.pytorch.org/pr/pytorch/executorch/7014#33343946883) ([gh](https://github.com/pytorch/executorch/actions/runs/11960284804/job/33343946883)) `RuntimeError: Error checking labels: PR does not have required labels`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 13 hours ago

This pull request was exported from Phabricator. Differential Revision: D66174765

github-actions[bot] commented 13 hours ago

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.