pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
2.2k stars 368 forks source link

[ET-VK] Using a single GPU buffer for all tensor uniforms. #7015

Open trivedivivek opened 13 hours ago

trivedivivek commented 13 hours ago

Stack from ghstack (oldest at bottom):

This diff changes Tensor class to store all uniforms in a single uniform buffer.

Entities stored in uniforms ie. size, stride, numel and logical limits are now stored in a single buffer and their offsets are stored as unsigned ints in Tensor class.

Other changes includes: Adding a new ctor for ParamsBuffer class to allow allocation with size without data ptr.

Adding an offset input to Buffer::data function.

Adding an offset parameter to BufferBindInfo ctor, so additional offset can be supplied when binding a buffer.

Differential Revision: D65841750

pytorch-bot[bot] commented 13 hours ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7015

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

:x: 2 New Failures

As of commit 700a4733ec97c97127b4e1e5817a7715cb31ab2a with merge base 7375cf5ac9c01bb1e4798a4ee4bdbdb5dfccfb0d (image):

NEW FAILURES - The following jobs have failed:

* [Check Labels / Check labels](https://hud.pytorch.org/pr/pytorch/executorch/7015#33343950247) ([gh](https://github.com/pytorch/executorch/actions/runs/11960286066/job/33343950247)) `RuntimeError: Error checking labels: PR does not have required labels` * [pull / unittest / linux / linux-job](https://hud.pytorch.org/pr/pytorch/executorch/7015#33343952105) ([gh](https://github.com/pytorch/executorch/actions/runs/11960281892/job/33343952105)) `RuntimeError: Command docker exec -t 950959d1dca572c261faf761546181b2a1c79793a6e6f330846017c7a1328070 /exec failed with exit code 139`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot commented 13 hours ago

This pull request was exported from Phabricator. Differential Revision: D65841750

github-actions[bot] commented 13 hours ago

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.