search

pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
2.2k stars 368 forks source link

Revert "[Executorch][Portable] Dont upcast to double for sigmoid" #7021

Closed swolchok closed 11 hours ago

swolchok commented 11 hours ago

This reverts commit c242a59e5860fd1761fef7c379c69a06b6bfa910. Attempting to debug/fix #7019.

pytorch-bot[bot] commented 11 hours ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7021

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

:x: 1 New Failure

As of commit fa6246b72f884a136d89a6180826524eff089557 with merge base 0070680ce04e274aaa4c2082e2fb26335f6f9f13 (image):

NEW FAILURE - The following job has failed:

* [Check Labels / Check labels](https://hud.pytorch.org/pr/pytorch/executorch/7021#33348982125) ([gh](https://github.com/pytorch/executorch/actions/runs/11961854768/job/33348982125)) `RuntimeError: Error checking labels: PR does not have required labels`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions[bot] commented 11 hours ago

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

swolchok commented 11 hours ago

didn't fix it