search

pytorch / executorch

On-device AI across mobile, embedded and edge for PyTorch
https://pytorch.org/executorch/
Other
2.2k stars 368 forks source link

Qaulcomm AI Engine Direct - Fix quantization annotation for per channel quant #7026

Open shewu-quic opened 6 hours ago

shewu-quic commented 6 hours ago

summary:

pytorch-bot[bot] commented 6 hours ago

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7026

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

:x: 1 New Failure

As of commit 5d85cf187c6beb70c272668151bce7b70796e206 with merge base 97b58bb84607ba4270c686356181c37feccf82eb (image):

NEW FAILURE - The following job has failed:

* [Check Labels / Check labels](https://hud.pytorch.org/pr/pytorch/executorch/7026#33358245446) ([gh](https://github.com/pytorch/executorch/actions/runs/11964990401/job/33358245446)) `RuntimeError: Error checking labels: PR does not have required labels`

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions[bot] commented 6 hours ago

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "topic: not user facing"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

shewu-quic commented 6 hours ago

Hi @cccclai,

The PR is to enable to set the act_observer for per-channel quant which to align the observer with other nodes. Could you help to take a look?

Thanks, Hutton

cccclai commented 4 hours ago

@navsud can you help with verifying