search

pytorch / extension-cpp

C++ extensions in PyTorch
1.02k stars 214 forks source link

Use dispatcher API #83

Open b-koopman opened 1 year ago

b-koopman commented 1 year ago

Custom C++ and CUDA Extensions tutorial is updated to use dispatcher API.

Updating tutorial to support tutorial changes as part of: https://github.com/pytorch/tutorials/issues/1495

facebook-github-bot commented 1 year ago

Hi @b-koopman!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

ClementPinard commented 1 year ago

Hey, thanks for putting me as reviewer. Waiting for the tutorial part to better understand the dispatcher API and I'll finish my review ASAP.

Overall, looks good to me, even though the part where you load the cpp module with pkg_resources could be removed from check.py and grad_check.py` and only be present in the lltm.py files for better clarity and less code replication