search

pytorch / extension-cpp

C++ extensions in PyTorch
1.02k stars 214 forks source link

Adding new cmake/scikitbuild core based workflow #85

Open drisspg opened 7 months ago

ClementPinard commented 7 months ago

Is this repo still being updated ? Last pushed commit was 5 years ago, so I though it was mainly archived, and seeing a Meta employee submitting a new PR after all this time is weird.

Anyway, I suppose it's still very early development since I can see all sorts of driss_torch mentions in the code.

The introduction of a Makefile is actually very interesting, but I suppose the tutorial should mention that somewhere as well

drisspg commented 7 months ago

@ClementPinard This repo has been archived for some number of time. There has been an influx of new cpp/cuda extensions in the PyTorch Community; flash-attention, mamba, bitsandbytes... One common problem is that extensions dont interact correctly with torch.compile. @zou3519 and I are going to work on updating this repo to provide clean templates for users.

The state of this PR is still very drafty