pytorch / functorch

functorch is JAX-like composable function transforms for PyTorch.

https://pytorch.org/functorch/

BSD 3-Clause "New" or "Revised" License

1.39k stars 102 forks source link

kl_div tests will fail on linux cpu until binaries update #932

Closed samdow closed 2 years ago

samdow commented 2 years ago

931 adds skips instead of xfails for the `vmapjvpall`, `vmapvjp_has_batch_rule`, and `jvpvjp` tests for kl_div. These skips are only necessary to get a green build because the linux cpu binaries didn't update on 7/4. When they update we should be able to remove these skip as the tests now pass on all our other builds (linux_cuda, windows, and mac)

samdow commented 2 years ago

Binaries were updated, removed skips

samdow commented 2 years ago

Reopening, seems like the failures are still happening. Once again very confusing since it only fails on cpu-only builds and I don't see it locally

samdow commented 2 years ago

It looks like the root cause of the passing was making kl_div composite (https://github.com/pytorch/pytorch/pull/80334). This got reverted since the issue got put up, so if we wait for the reland this should work for all devices