search

pytorch / functorch

functorch is JAX-like composable function transforms for PyTorch.
https://pytorch.org/functorch/
BSD 3-Clause "New" or "Revised" License
1.39k stars 102 forks source link

Reenable tests after https://github.com/pytorch/pytorch/pull/80217 lands #961

Open zou3519 opened 2 years ago

zou3519 commented 2 years ago
lezcano commented 2 years ago

fwiw, these two tests should pass once https://github.com/pytorch/pytorch/pull/80217 is merged

lezcano commented 2 years ago

or at least the second one. I'm not sure what's making the first one fail.

zou3519 commented 2 years ago

We don't have to support det for now for that test, so please feel free to merge https://github.com/pytorch/pytorch/pull/80217 and we can worry about that test later.

zou3519 commented 2 years ago

@Lezcano will https://github.com/pytorch/pytorch/pull/80217 land soon? If not, since functorch is in pytorch/pytorch now, I want to reenable the above tests to prevent regressions

lezcano commented 2 years ago

I'm on PTO, I'll look at this when I'm back. Feel free to activate the tests again, and I can skip them or fix them in the pr

zou3519 commented 2 years ago

Cool, going to re-enable them. If it's not too difficult we should try to fix them in the PR to avoid regressions

lezcano commented 2 years ago

It looks like that PR is about to land. Sorry for the very long wait, but I've been a fair amount of time out on PTO

zou3519 commented 2 years ago

Np, let's land your PR first and then figure out what is going on with the tests

lezcano commented 2 years ago

It landed, it was reverted, then it landed again. Let's see if it sticks this time.