search

pytorch / functorch

functorch is JAX-like composable function transforms for PyTorch.
https://pytorch.org/functorch/
BSD 3-Clause "New" or "Revised" License
1.39k stars 102 forks source link

0.2.1 batch norm fixes #994

Closed samdow closed 2 years ago

samdow commented 2 years ago

Adds two commits for batch norm bug fixes. From discussion on #273 and #867

cc @zou3519 I ended up cherry-picking two commits since #958 also caught a typo and need for a contiguous call. However, lines-wise, this ends up being a lot of testing changes. I think I can refactor both changes to have fewer testing changes but will end up looking different than the version on main. Any thoughts as to if I should keep it like this or try to refactor for fewer test changes?

samdow commented 2 years ago

Change: since it's failing so many tests I'm going to go with option 1 and try to re-cherry-pick with very minimal testing changes

zou3519 commented 2 years ago

Change: since it's failing so many tests I'm going to go with option 1 and try to re-cherry-pick with very minimal testing changes

Sounds good

zou3519 commented 2 years ago

I wouldn't worry about the mac signal -- the macos signal is failing because they deprecated the xcode image I think

samdow commented 2 years ago

Circle CI shows passing for all jobs but mac. Looks like github checks aren't updating