search

pytorch / glow

Compiler for Neural Network hardware accelerators
Apache License 2.0
3.24k stars 692 forks source link

Cleanup the Glow CMake file #3029

Open nadavrot opened 5 years ago

nadavrot commented 5 years ago

The main Glow CMake file is long and has a bunch of commands and definitions. We should move most of the definitions to submodule cmake files that we include. For example:

This is good:

include(GlowDefaults)

This should move into a CMake include file.

102 # Find habanalabs libraries. 103 list(APPEND CMAKE_PREFIX_PATH /usr/lib/habanalabs) 104 find_path(SYNAPSE_INCLUDE_DIR synapse.h) 105 find_library(SYNAPSE_LIB Synapse) 106 find_library(TPCSIM_SHARED_LIB tpcsim_shared) 107 find_library(HL_THUNK_LIB hl-thunk)

psyhtest commented 4 years ago

It appears that a third-party won't be able to build the Habana backend since the paths are hardcoded (/usr/lib/habanalabs)?

psyhtest commented 4 years ago

cc: @bertmaher