search

pytorch / hub

Submission to https://pytorch.org/hub/
1.38k stars 240 forks source link

Fix typo in 3D ResNet #302

Closed cpprhtn closed 1 year ago

cpprhtn commented 1 year ago

@NicolasHug

I just found a simple typo error. In 3D ResNet (facebookresearch_pytorchvideo_resnet.md), table is broken.

arch depth frame length x sample rate top 1 top 5 Flops (G) Params (M)
Slow R50 8x8 74.58 91.63 54.52 32.45
👇 arch depth frame length x sample rate top 1 top 5 Flops (G) Params (M)
Slow R50 8x8 74.58 91.63 54.52 32.45
facebook-github-bot commented 1 year ago

Hi @cpprhtn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

netlify[bot] commented 1 year ago

Deploy Preview for pytorch-hub-preview ready!

Name Link
Latest commit badb574a15cc3b58f688c9ffa19a4b9c3c434203
Latest deploy log https://app.netlify.com/sites/pytorch-hub-preview/deploys/6309f30b0d02e30007bb3255
Deploy Preview https://deploy-preview-302--pytorch-hub-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

NicolasHug commented 1 year ago

Thanks for the PR @cpprhtn

Looking at the rendering on this PR: https://deploy-preview-302--pytorch-hub-preview.netlify.app/hub/facebookresearch_pytorchvideo_resnet/

it looks like the table is still missing something. Perhaps it's because we need to leave a blank line before the table, i.e. right after this sentence?

The model architecture is based on [1] with pretrained weights using the 8x8 setting on the Kinetics dataset.

cpprhtn commented 1 year ago

@NicolasHug

Thank you for letting me know. I sent the PR again after reflecting the feedback.