pytorch / ignite

High-level library to help with training and evaluating neural networks in PyTorch flexibly and transparently.
https://pytorch-ignite.ai
BSD 3-Clause "New" or "Revised" License
4.51k stars 610 forks source link

[FR] Add kwargs to `idist.barrier` #2213

Open vfdev-5 opened 2 years ago

vfdev-5 commented 2 years ago

🚀 Feature

A feature request to add kwargs to idist.barrier.

sdesrozis commented 2 years ago

Note :

The parameters name for horovod and tag (replicas ?) for xla could be defined.

fco-dv commented 2 years ago

I can try to tackle this one!

fco-dv commented 2 years ago

@sdesrozis for horovod : https://github.com/horovod/horovod/blob/66ad6d5a3586decdac356e8ec95c204990bbc3d6/horovod/torch/mpi_ops.py#L974 seems to have added a barrier method, could it be a replacement of the workaround implemented here : https://github.com/pytorch/ignite/blob/4a37e35dcb9548bb777dc86ab649ff390c6fb631/ignite/distributed/comp_models/horovod.py#L197 ?

sdesrozis commented 2 years ago

@fco-dv Yes but it's pretty recent, so we should handle previous horovod version.