pytorch / ignite

High-level library to help with training and evaluating neural networks in PyTorch flexibly and transparently.

https://pytorch-ignite.ai

BSD 3-Clause "New" or "Revised" License

4.55k stars 620 forks source link

Fix warning in the test for SSIM metric #2358

Closed vfdev-5 closed 2 years ago

vfdev-5 commented 2 years ago

🚀 Feature

We can see on the CI that we are using a deprecated arg.

tests/ignite/metrics/test_ssim.py::test_ssim
  /home/runner/work/ignite/ignite/tests/ignite/metrics/test_ssim.py:79: FutureWarning: `multichannel` is a deprecated argument name for `structural_similarity`. It will be removed in version 1.0.Please use `channel_axis` instead.
    skimg_ssim = ski_ssim(

The idea is to fix that as suggested by skimage doc and the message.

bibhabasumohapatra commented 2 years ago

hey @vfdev-5 I have changed the multichannel = True to channel_axis = -1, This is my first pull request, Let me know if I miss something.

2360

bibhabasumohapatra commented 2 years ago

https://github.com/scikit-image/scikit-image/issues/4294

bibhabasumohapatra commented 2 years ago

my pull request fixes the warnings first one is the master branch and second is my new branch1 changes