Explicitly run miniconda with `bash`

pytorch / multipy

torch::deploy (multipy for non-torch uses) is a system that lets you get around the GIL problem by running multiple Python interpreters in a single C++ process.

Other

173 stars 35 forks source link

Explicitly run miniconda with `bash` #283

Closed hatala91 closed 1 year ago

hatala91 commented 1 year ago

A change to the Miniconda3-latest-Linux-x86_64.sh has it use bash syntax - namely [[ ]] - while declaring a #!/bin/sh shebang.

With this PR I propose to explicitly run the miniconda executable using bash.

facebook-github-bot commented 1 year ago

@hatala91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

hatala91 commented 1 year ago

Forgot to mention: This causes tests to fail on main at the moment https://github.com/pytorch/multipy/actions/runs/3762635058

facebook-github-bot commented 1 year ago

@hatala91 merged this pull request in pytorch/multipy@bc093e41aa25af5a92410c9d4c716bdc86fb0029.